Skip to content

docs[lowerFirst]: fix JSDoc examples calling lowerCase instead of lowerFirst - #2132

Merged
raon0211 merged 2 commits into
toss:mainfrom
minseonkkim:docs/fix-jsdoc-examples
Oct 8, 2026
Merged

raon0211 merged 2 commits into
toss:mainfrom
minseonkkim:docs/fix-jsdoc-examples

Conversation

@minseonkkim

@minseonkkim minseonkkim commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The JSDoc examples for lowerFirst call lowerCase instead of lowerFirst.

Because of this, the examples don't match their own comments. For example, lowerCase('FRED') returns 'fred', but the comment says 'fRED' (which is the correct result for lowerFirst).

This was previously fixed in #1324, but that PR only updated docs/ja/reference/string/lowerFirst.md. The JSDoc in the source files was left unchanged.

Changes

  • src/string/lowerFirst.ts: replace lowerCase with lowerFirst in the three JSDoc examples
  • src/compat/string/lowerFirst.ts: same change
  • The expected results in the comments were already correct for lowerFirst, so they are unchanged
  • The markdown docs in all four languages are already correct, so no changes were needed there

@vercel

vercel Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
es-toolkit Error Error Oct 8, 2026 9:53am UTC

Request Review

@raon0211
raon0211 merged commit 692c568 into toss:main Oct 8, 2026
10 of 11 checks passed

This branch had an error being deployed

1 failed deployment
Preview — 86a0cfa4 Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants